Mark Brown [off-list ref] hat am 7. Mai 2015 um 20:52 geschrieben:


On Thu, May 07, 2015 at 08:37:18PM +0200, Stefan Wahren wrote:

quoted

quoted

Stefan Wahren [off-list ref] hat am 4. Mai 2015 um 22:34

quoted

quoted

i'm sorry, i forgot the following point in the changelog:

quoted

quoted

- move dcdc handling from mxs_power to mxs-regulator

quoted

quoted

I hope the change is okay. I implemented only is_enabled() to have at
least 1
operation.
But it's not really necessary.

quoted

do we need enable / disable operation?

quoted

In the bootloader code enabling the DC-DC is critical. There is a known
issue
which falsely triggers the brownout detection.

Why would the driver not provide these operations?

I didn't implement this operation because the suggested workaround for the
hardware issue isn't very nice 
(disable brownout detection during enabling DC-DC). I was afraid of the
implementation.

quoted

quoted

quoted

I'm also not 100% clear what code the DCDCs and LDOs are
sharing here...

quoted

quoted

Actually only probing and the regulator info structure.

quoted

How can i improve that?

If the devices aren't sharing code then they should be separate drivers.

Okay. 

mxs-regulator-ldo.c
mxs-regulator-dcdc.c

What do you think of?