2015-05-29 8:57 GMT+02:00 Joachim  Eastwood [off-list ref]:

Hi Matthias,

On 28 May 2015 at 20:41, Matthias Brugger [off-list ref] wrote:

quoted

Some devices like SoCs from Mediatek need to use the clock muxes
through a regmap interface.
This patch adds regmap support for simple the simple multiplexer
clock code.

Nice to see regmap support. This something I would also like to see
added to the clk framework.
And if the approach is agreed upon I would like to see support on
gates and dividers also.

I totally agree.

quoted

+static void clk_mux_writel(struct clk_mux *mux, u32 val)
+{
+       if (mux->flags && CLK_MUX_USE_REGMAP)

Assume you mean &.

Sure, it's just luck that the patch didn't end up with a hanging
system when I tested it yesterday.
Fixed in next version.

quoted

+               regmap_write(mux->regmap, mux->offset, val);
+       else
+               clk_writel(val, mux->reg);
+}
+
+static u32 clk_mux_readl(struct clk_mux *mux)
+{
+       u32 val;
+
+       if (mux->flags && CLK_MUX_USE_REGMAP)

And here.

Ditto.

quoted

+               regmap_read(mux->regmap, mux->offset, &val);
+       else
+               val = clk_readl(mux->reg);
+
+       return val;
+}
+

[...]

quoted

@@ -409,7 +410,9 @@ void clk_unregister_divider(struct clk *clk);
 struct clk_mux {
        struct clk_hw   hw;

quoted

        void __iomem    *reg;
+       struct regmap   *regmap;

Since it not possible to have both iomem and regmap at the same time.
Could this be put in a union or does that make registration more
difficult?

It just adds a flag check to the registration.
I will add it in the next version.

Thanks for reviewing.
Matthias


-- 
motzblog.wordpress.com