Thread (70 messages) flat view 70 messages, 15 authors, 2015-06-23

[PATCH 15/21] backlight: Probe backlight devices on demand

From: Lee Jones <hidden>
Date: 2015-05-26 13:34:34
Also in: linux-fbdev, lkml

On Tue, 26 May 2015, Tomeu Vizoso wrote:
On 26 May 2015 at 10:39, Lee Jones [off-list ref] wrote:
quoted
On Tue, 26 May 2015, Sascha Hauer wrote:
quoted
On Tue, May 26, 2015 at 08:18:50AM +0100, Lee Jones wrote:
quoted
On Mon, 25 May 2015, Tomeu Vizoso wrote:
quoted
When looking up a backlight device through its DT node, ensure that the
corresponding device has been registered.

Signed-off-by: Tomeu Vizoso <redacted>
---
 drivers/video/backlight/backlight.c | 3 +++
 1 file changed, 3 insertions(+)
Looks reasonable.

Until anyone screams at me, applied thanks.
The compiler will scream at you when it realizes that
of_platform_device_ensure() doesn't exist in your kernel...
Yup, indeed it did.

I assumed this was *only* enabling subsystems and that the
framework/API was already accepted.

So the advice I'd give to Tomeu when sending full enablement
patch-sets i.e. ones which provide the framework/API *and* enable
subsystems in the same set, is to send the entire set to everyone, so
we can see what the aim of the set is and how to deal with it.
Yeah, but get_maintainer.pl outputs 33 maintainer addresses, plus 1
reviewer plus 14 mailing lists, so to avoid rejects because of too
many recipients I went with the advice in [0] and sent each patch to
their maintainers and list(s) and the cover letter to all lists. Also
sent the whole series to lakml to make sure that it's at least indexed
there.
Mails aren't usually rejected because they have too many recipients,
rather they require approval.  This isn't a blocker, especially for
patch-sets like this.
Any advice on what to do with series that span so many subsystems?
I would either ensure everyone is informed, split into two choices;
either CC everyone on every patch, or at least everyone on the
cover-letter and the core API changes.  The other method is to have
the API changes accepted first, then once accepted send out the
subsystem changes [FWIW: this is the method I (wrongly) assumed you
used].

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help