Thread (1 message) 1 message, 1 author, 2015-05-25

[PATCH net-next v5 2/2] net: Adding support for Cavium ThunderX network controller

From: davem@davemloft.net (David Miller)
Date: 2015-05-25 21:33:53
Also in: lkml, netdev

From: Aleksey Makarov <redacted>
Date: Fri, 22 May 2015 18:28:16 -0700
+#ifdef NOT_SUPPORTED_FOR_NOW
+static int nicvf_set_coalesce(struct net_device *netdev,
+			      struct ethtool_coalesce *cmd)
+{
 ...
+#ifdef NOT_SUPPORTED_FOR_NOW
+	.set_coalesce		= nicvf_set_coalesce,
+#endif
+	.get_ringparam		= nicvf_get_ringparam,
Remove this completely.  When you actually make it work and want to
enable it, you can re-add the code.

The upstream kernel is not your personal workspace :-)
+#ifdef VNIC_RSS_SUPPORT
This is unconditionally defined in one of your headers, please remove
these ifdefs as they will never be false.
+#ifdef VNIC_RSS_SUPPORT
Likewise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help