[linux-sunxi] Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator

Le 15/05/2015 08:49, Herbert Xu a ?crit :

On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:

quoted

+	err = crypto_ablkcipher_setkey(op->fallback, kkey, op->keylen);
+	if (err != 0) {
+		dev_err(ss->dev, "Cannot set key on fallback\n");
+		return -EINVAL;
+	}

You cannot call setkey from an atomic context.  The easiest solution
is to call setkey in your setkey function instead.

Cheers,

Fixed

What do you think about adding a BUG_ON(in_atomic()) in crypto_ablkcipher_setkey() ?

Thanks