Thread (6 messages) 6 messages, 3 authors, 2015-05-19

[PATCH] [RESEND] SCSI: ips: remove pointless #warning

From: joe@perches.com (Joe Perches)
Date: 2015-05-19 19:25:44
Also in: linux-scsi, lkml

On Tue, 2015-05-19 at 11:38 -0700, James Bottomley wrote:
On Tue, 2015-05-19 at 15:56 +0200, Arnd Bergmann wrote:
quoted
On Tuesday 19 May 2015 06:52:52 James Bottomley wrote:
quoted
On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote:
quoted
The ips driver contains
 #warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
trivial:
quoted
My main interest here is to get a clean build of ARM 'allmodconfig'.
[]
What about this?  It captures the intent of the
original but gets rid of the warning.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
[]
quoted hunk ↗ jump to hunk
@@ -6788,6 +6784,11 @@ ips_remove_device(struct pci_dev *pci_dev)
 static int __init
 ips_module_init(void)
 {
+#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)
+        printk(KERN_ERR, "ips: This driver has only been tested on the x86/ia64/x86_64 platforms\n");
Bad comma after KERN_ERR, and KERN_ALERT might be better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help