Thread (4 messages) flat view 4 messages, 4 authors, 2015-05-19

[RFC] arm: Add for atomic half word exchange

From: peterz@infradead.org (Peter Zijlstra)
Date: 2015-05-19 12:43:44
Also in: lkml

On Tue, May 19, 2015 at 11:20:13AM +0000, Sarbojit Ganguly wrote:
On Tuesday 19 May 2015 09:39:33 Sarbojit Ganguly wrote:
quoted
Since 16 bit half word exchange was not there and MCS based
qspinlock by Waiman's xchg_tail() requires an atomic exchange on a
half word, here is a small modification to __xchg() code.
Can you actually see a performance improvement with the qspinlock code
on ARM ?

The real improvements on x86 were on NUMA systems; although there were
real improvements on light loads as well.


Note that ARM (or any load-store arch) could get rid of all the cmpxchg
loops in that code. Although I suppose we replaced the most common ones
with these unconditional atomics already -- like that xchg16 -- so
implementing those with ll/sc, as you did, should be near optimal.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help