[PATCH] crypto: allow to assign gfp_t for __crypto_alloc_tfm
From: herbert@gondor.apana.org.au (Herbert Xu)
Date: 2015-05-19 07:15:34
Also in:
linux-crypto, linux-ext4, linux-f2fs-devel, lkml
On Tue, May 19, 2015 at 12:13:17AM -0700, Jaegeuk Kim wrote:
The key generation is done by ext4_generate_encryption_key in fs/ext4/crypto_key.c. And, ext4_file_mmap and ext4_file_open trigger it.
Well that's where you should be doing crypto_alloc_ablkcipher and crypto_ablkcipher_setkey. The whole point of a crypto tfm is to represent a key so any time you get one you should create a crypto tfm. Carrying around a raw key is just wrong. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt