Automatic clock disabling on clk_put()
From: Stephen Boyd <hidden>
Date: 2015-05-12 23:23:53
Also in:
linux-clk, lkml
On 05/10/15 23:01, Sascha Hauer wrote:
Hi, Since we now have per-user clks we could automatically disable clks on clk_put() to make the drivers errors paths easier. AFAIR that was one of the motivations to switch to per user clks. Is this just not yet implemented or are there problems implementing this?
I don't recall that as being a motivation for per-user clks. The documentation explicitly states: * Note: drivers must ensure that all clk_enable calls made on this * clock source are balanced by clk_disable calls prior to calling * this function. so it seems that such a behavior would be an API change. Is it really that hard to call clk_disable_unprepare() on a clock at the end of an error path? Maybe you could add a devm_clk_get_prepare_enable() that does what you want and then call clk_disable_unprepare on the exit path? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project