Thread (1 message) 1 message, 1 author, 2015-05-04
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[patch] ARM: fix module-bound check in setting page attributes

From: Hillf Danton <hidden>
Date: 2015-05-04 02:53:27
Also in: lkml

It was introduced in commit f2ca09f381a59
(ARM: 8311/1: Don't use is_module_addr in setting page attributes)

We have no need to check start twice, but see if end is also in range.

Signed-off-by: Hillf Danton <redacted>
Acked-by: Laura Abbott <redacted>
---
--- a/arch/arm/mm/pageattr.c	Mon May  4 10:33:49 2015
+++ b/arch/arm/mm/pageattr.c	Mon May  4 10:35:32 2015
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned
 	if (start < MODULES_VADDR || start >= MODULES_END)
 		return -EINVAL;
 
-	if (end < MODULES_VADDR || start >= MODULES_END)
+	if (end < MODULES_VADDR || end >= MODULES_END)
 		return -EINVAL;
 
 	data.set_mask = set_mask;
--
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help