[PATCHv3 34/35] ARM: dts: dra7: add system control module node
From: tony@atomide.com (Tony Lindgren)
Date: 2015-03-11 17:17:08
Also in:
linux-omap
Hi Tero, * Tero Kristo [off-list ref] [150225 11:09]:
Add node for system control module, and move all the existing system control IO space users under this new node as its children. A new node for scm_conf area is also added.
...
quoted hunk ↗ jump to hunk
--- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi@@ -203,26 +203,47 @@ }; }; + scm: scm at 4a002000 { + compatible = "ti,dra7-ctrl", "simple-bus"; + reg = <0x4a002000 0x1400>, + <0x4a003400 0x600>, + <0x4ae0c000 0x600>; + #address-cells = <2>; + #size-cells = <1>; + ranges = <0 0 0x4a002000 0x1400>, + <1 0 0x4a003400 0x600>, + <2 0 0x4ae0c000 0x600>; + + scm_conf: tisyscon at 0,0 { + compatible = "syscon"; + reg = <0 0x0 0x1400>; + #address-cells = <1>; + #size-cells = <1>; + }; + + dra7_pmx_core: pinmux at 1,0 { + compatible = "ti,dra7-padconf", + "pinctrl-single"; + reg = <1 0x0 0x0464>; + #address-cells = <1>; + #size-cells = <0>; + #interrupt-cells = <1>; + interrupt-controller; + pinctrl-single,register-width = <32>; + pinctrl-single,function-mask = <0x3fffffff>; + }; + };
Wouldn't it make more sense to have separate device_scm, core_scm and wkup_scm instead of stuffing multiple ranges here? Or are there other reasons for the multiple ranges? Regards, Tony