Thread (9 messages) 9 messages, 4 authors, 2015-04-02

[PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature

From: Linus Walleij <hidden>
Date: 2015-03-27 09:07:30
Also in: linux-gpio

On Fri, Mar 20, 2015 at 8:12 PM, Alexander Stein [off-list ref] wrote:
This adds the callback for set_multiple.
As this controller has a separate set and clear register, we can't write
directly to PIO_ODSR as this would required a cached variable and would
race with at91_gpio_set.
So build masks for the PIO_SODR and PIO_CODR registers and write them
together.

Signed-off-by: Alexander Stein <redacted>
---
This was tested by using an own test driver which uses
gpiod_set_array_cansleep to set multiple GPIOs at once.
I remember J-C brought this up ages ago, so I hope he will be delighted
to see we can now, FINALLY, do this!

J-C can I have your review on this?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help