Thread (3 messages) 3 messages, 2 authors, 2015-03-27

[PATCH] pinctrl: mvebu: add suspend/resume support to Armada XP pinctrl driver

From: Linus Walleij <hidden>
Date: 2015-03-27 08:37:19
Also in: linux-gpio

On Thu, Mar 19, 2015 at 11:30 AM, Thomas Petazzoni
[off-list ref] wrote:
This commit adds suspend/resume support to the Armada XP pinctrl
driver, by simply saving and restoring the MPP registers.

Signed-off-by: Thomas Petazzoni <redacted>
Patch applied, but:
 static void __iomem *mpp_base;
+static u32 *mpp_saved_regs;
I didn't notice this singleton design pattern in this driver before :(
I see the legacy Dove driver have a few more.

Can we have a mvebu refactoring patch bringing these things into a state
container? Like a per-subdriver kmalloc:ed struct foo_state {}?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help