Thread (11 messages) 11 messages, 3 authors, 2015-04-30

[PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked.

From: Maxime Coquelin <hidden>
Date: 2015-03-31 15:34:06
Also in: linux-devicetree, linux-ide, lkml

Hello Tejun,

On 03/31/2015 05:29 PM, Tejun Heo wrote:
On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote:
quoted
Currently the ahci_st driver will hang the system on probe, as the
st_configure_oob function does some register writes before the IP
is clocked. This patch moves the function call to after
ahci_platform_enable_resources (which enables the IP clock), and
resolves the hang.

Addtionally st_ahci_configure_oob should be called in the st_ahci_resume
function, so we also rectify that ensuring it is also called after
the IP clock has been enabled.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Acked-by: Lee Jones <redacted>
Acked-by: Maxime Coquelin <redacted>
How should this patch be routed?  Should I pick this up and apply to
libata/for-4.1 or should it go together with the other patches?  If
the latter, please feel free to add my acked-by.
I think you can pick patches 1 & 3.
I will apply patch 2 to STi DT branch.

Thanks,
Maxime
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help