[PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
From: Peter Ujfalusi <hidden>
Date: 2015-03-31 14:49:25
Also in:
linux-devicetree, linux-omap, lkml
From: Peter Ujfalusi <hidden>
Date: 2015-03-31 14:49:25
Also in:
linux-devicetree, linux-omap, lkml
On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote:
On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:quoted
+ if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node, + "dma-requests", + &od->dma_requests)) { + dev_info(&pdev->dev, + "Missing dma-requests property, using %u.\n", + OMAP_SDMA_REQUESTS); + od->dma_requests = OMAP_SDMA_REQUESTS; + }Are all OMAPs including OMAP1 being converted to DT? If not, don't introduce noisy printks for which a platform can't do anything about. Think about this please - if there's no of_node, then why complain about a missing OF property?
Yes, you are perfectly right on this. Will fix it up. Thanks, P?ter