Thread (9 messages) 9 messages, 4 authors, 2015-03-17

[PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688

From: tony@atomide.com (Tony Lindgren)
Date: 2015-03-17 16:39:30
Also in: linux-omap, lkml

* Nishanth Menon [off-list ref] [150317 09:32]:
On 03/17/2015 11:26 AM, santosh shilimkar wrote:
quoted

On 3/16/2015 4:30 PM, Tony Lindgren wrote:
quoted
* Stefan Hengelein [off-list ref] [150225 10:48]:
quoted
The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a
contradiction in it's dependencies.
The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an
enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be
enabled. These options inherit a dependency from an enclosing menu,
that requires ARCH_MULTIPLATFORM to be 'enabled'.
This is a contradiction and made this option also unavailable for
non-multiplatform configurations.

Since there are no selects on OMAP4_ERRATA_I688, which would ignore
dependencies, the code related to that option is dead and can be
removed.

This (logical) defect has been found with the undertaker tool.
(https://undertaker.cs.fau.de)

Signed-off-by: Stefan Hengelein <redacted>

---
Tony Lindgren suggested to remove the code since nobody complained for
a few years and Santosh Shilimkar agreed.
https://lkml.org/lkml/2015/2/25/449
---
As far as I see, this should remove all the code related to
OMAP4_ERRATA_I688, I hope I didn't remove too much.
Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent.
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
We no longer need i688? I do understand the need to cleanup the macros
for multi-arch etc.. but loosing a bug workaround for a real silicon
bug is really an invitation for hard to debug issues IMHO.
Well that code has not been selectable for a few years now. Naturally
we can add it back when it actually does something with multiarch.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help