Hello,

On Fri, Feb 27, 2015 at 09:46:11AM -0800, Dmitry Torokhov wrote:

On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-K?nig wrote:

quoted

On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:

quoted

On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni [off-list ref] wrote:

quoted

Dear S?bastien SZYMANSKI,

On Fri, 27 Feb 2015 12:09:51 +0100, S?bastien SZYMANSKI wrote:

quoted

        error = input_register_device(sx8654->input);
        if (error)
                return error;

Where is your ->remove() function that unregisters the input device?

Everything seems to be allocated with devm so remove is not needed.

Everything is devm_* but input_register_device, right?

Input is allocated with devm_* and input_register_device knows how to
deal with that:

ah, something new each day. Thanks for teaching me.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |