[PATCH 4/8] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets
From: andrew@lunn.ch (Andrew Lunn)
Date: 2015-02-16 17:54:55
On Mon, Feb 16, 2015 at 04:52:54PM +0000, Russell King - ARM Linux wrote:
On Mon, Feb 16, 2015 at 05:30:24PM +0100, Sebastian Hesselbarth wrote:quoted
On 16.02.2015 16:58, Russell King - ARM Linux wrote:quoted
On Sat, Feb 14, 2015 at 06:02:11PM +0100, Sebastian Hesselbarth wrote:quoted
How about we copy the clk subsystem way of installing early probed pm for DT here? For example: #define PM_OF_DECLARE(name, compat, fn) OF_DECLARE_1(clk, name, compat, fn) and static int __init dove_pmu_init(struct device_node *np) { ... } PM_OF_DECLARE(dove_pmu, "marvell,dove-pmu", dove_init_pmu);Well, Rob's response was basically "use the machine descriptor" so I guess it needs to be explicitly called from arch/arm/mach-mvebu/dove.c:dove_init().Ok, I am very fine with that, too. Still, we'd have to find a proper place for the driver, don't we?Yep - I'm not sure creating drivers/pmu for (at the moment) one driver is a particularly good idea. Maybe something in drivers/soc/ ?
If you did create drivers/pmu, you could move drives/soc/pmc.c into
it.
But drivers/soc also seems like a good place for the dove PMU code.
Andrew