On Wed, Feb 4, 2015 at 7:44 AM, Rob Herring [off-list ref] wrote:

On Wed, Feb 4, 2015 at 7:25 AM, Arnd Bergmann [off-list ref] wrote:

quoted

On Tuesday 03 February 2015 17:22:53 Rob Herring wrote:

quoted

SA1100 and PXA differ only in register offsets which are currently
hardcoded in a machine specific header. Some arm64 platforms (PXA1928)
have this RTC block also.

Convert the driver to use ioremap and set the register offsets dynamically.
Since we are touching all the register accesses, convert them all to
readl/writel.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Alessandro Zummo <redacted>
Cc: rtc-linux at googlegroups.com

Hmm, I really should have sent out my version of the patch ages ago. :(

Got any others? :)

quoted

Can you have a look at

http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-3.19-next&id=4d9727883a363fb839e7d1633599166c0a08d644

to see compare the approaches and see if there is anything I did that you
missed?

You used the relaxed variants seems to be the main difference. Yours
won't build on arm64 either.

Also, I noticed the rtc-puv3 driver appears to be the same programming
model. The quirks around interrupt clearing seem to be a bit different
though.

Rob