Thread (6 messages) 6 messages, 4 authors, 2015-02-26

[PATCH v5 1/6] mfd: fsl imx25 Touchscreen ADC driver

From: festevam@gmail.com (Fabio Estevam)
Date: 2015-02-18 11:57:59
Also in: linux-devicetree, linux-iio, linux-input

On Wed, Feb 18, 2015 at 6:01 AM, Lee Jones [off-list ref] wrote:
On Tue, 17 Feb 2015, Fabio Estevam wrote:
quoted
On Mon, Feb 16, 2015 at 11:38 AM, Lee Jones [off-list ref] wrote:
quoted
quoted
+static int mx25_tsadc_setup_irq(struct platform_device *pdev,
+                             struct mx25_tsadc *tsadc)
+{
+     struct device *dev = &pdev->dev;
+     struct device_node *np = dev->of_node;
+     int irq;
+
+     irq = platform_get_irq(pdev, 0);
+     if (irq < 0) {
What if 0 is returned?
Then  imx25.dtsi would be passing irq=0 for the ADC, which would be
totally wrong.
Exactly, so it should be <=.
imx25.dtsi passes interrupts = <46>; for the touch screen controller,
so the irq number will never be zero.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help