Thread (1 message) 1 message, 1 author, 2015-02-06

[PATCH 2/4] Documentation: dt-bindings: add dt binding info for hi6220

From: zhangfei.gao@linaro.org (Zhangfei Gao)
Date: 2015-02-06 05:49:29
Also in: linux-devicetree

On 6 February 2015 at 02:24, Sergei Shtylyov
[off-list ref] wrote:
quoted
diff --git a/Documentation/devicetree/bindings/usb/hi6220-usb.txt
b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
new file mode 100644
index 0000000..e926364
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/hi6220-usb.txt
@@ -0,0 +1,50 @@
+Hisilicon hi6220  SoC USB controlle

   Controller.
Yes, my mistake.
To prevent spelling error next time, will paste to google doc first
for the auto spelling check.
quoted
+-----------------------------
+
+usb controller is inherited from dwc2, refer dwc2.txt
+-----
+
+Required properties:
+- compatible: "hisilicon,hi6220-usb-phy"

   PHY? I thought you were describing the USB controller.
my bad
should be compatible: "hisilicon,hi6220-usb"
quoted
+Refer to dwc2.txt for dwc2 usb properties
+
+
+phy:
change to PHY:
quoted
+-----
+
+Required properties:
+- compatible: "hisilicon,hi6220-usb-phy"
+- vcc-supply: phandle to the regulator that provides power to the PHY.
+- clocks: phandle to the PHY clock. Use as per Documentation/devicetree

   Actually, it's phandle and clock specifier.
Change to
 - clocks: phandle and clock specifier of the PHY clock.
quoted
+  /bindings/clock/clock-bindings.txt
+- hisilicon,peripheral-syscon: phandle of syscon used to control
peripheral.
+- hisilicon,gpio_vbus_det: gpio of detecting vbus.
+- hisilicon,gpio_id_det: gpio of detecting id.

   Hyphens are preferred over underscores in the prop names.
Change to
- hisilicon,gpio-vbus-det: gpio of detecting vbus.
- hisilicon,gpio-id-det: gpio of detecting id.

Thanks Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help