[PATCH] Fix offset2lib issue for x86*, ARM*, PowerPC and MIPS
From: akpm@linux-foundation.org (Andrew Morton)
Date: 2015-02-26 23:04:00
Also in:
linux-mips, linuxppc-dev, lkml
Possibly related (same subject, not in this thread)
- 2015-02-27 · Re: [PATCH] Fix offset2lib issue for x86*, ARM*, PowerPC and MIPS · Kees Cook <hidden>
On Thu, 26 Feb 2015 14:38:15 -0800 Andrew Morton [off-list ref] wrote:
Does that __weak trick even work?
Nope.
--- a/fs/binfmt_elf.c~fix-offset2lib-issue-for-x86-arm-powerpc-and-mips-fix-fix
+++ a/fs/binfmt_elf.c@@ -2307,10 +2307,10 @@ unsigned long __weak mmap_rnd(void) } /* - * Not all architectures use randomize_et_dyn(), so use __weak to let the - * linker omit it from vmlinux + * Not all architectures use randomize_et_dyn(), but there doesn't seem to be + * a compile-time way of avoiding its generation. */ -unsigned long __weak randomize_et_dyn(unsigned long base) +unsigned long randomize_et_dyn(unsigned long base) { unsigned long ret;
_