Thread (1 message) 1 message, 1 author, 2015-02-20

[PATCH] net: smc91x: improve neponset hack

From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2015-02-20 20:00:46
Also in: lkml, netdev

Arnd Bergmann [off-list ref] writes:
On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote:
quoted
On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote:
quoted
The smc91x driver tries to support multiple platforms at compile
time, but they are mutually exclusive at runtime, and not clearly
defined.
I'd prefer to rework this to fix that properly.  From what I remember,
the whole SA11x0 stuff in this driver was a mess.
I guess that's reasonable. I've looked through the driver and it seems we
did most of the multiplatform work but left a few things alone that should
have been converted a long time ago.

Can you check if the approach below makes sense to you?

I've verified that each machine that defines an smc91x device now sets
the correct platform data, irq flags and access width, which should be
enough to collapse all the CONFIG_ARM cases into one.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
When you're both satisfied with the smc91x patch, I can offer to test it across
the pxa boards (lubbock, zylonite, and maybe mainstone). As I'm actively using
the first 2, I'm interested in them being as functional as now :)

Cheers.

--
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help