[PATCH] ARM: OMAP2+: Return correct error values from device and hwmod
From: Pavel Machek <hidden>
Date: 2015-02-20 08:22:30
Also in:
linux-omap, lkml
On Fri 2015-02-20 00:41:41, Pali Roh?r wrote:
Without this patch function pm_runtime_get_sync() returns 0 even when some omap subfunction fails. This patch properly propagate error codes from omap functions back to caller. This patch fix problem, when loading omap-aes driver in qemu cause kernel oops.
"fixes"
Signed-off-by: Pali Roh?r <redacted>
Acked-by: Pavel Machek <redacted>
quoted hunk ↗ jump to hunk
@@ -3350,16 +3350,17 @@ int omap_hwmod_enable(struct omap_hwmod *oh) */ int omap_hwmod_idle(struct omap_hwmod *oh) { + int r; unsigned long flags; if (!oh) return -EINVAL; spin_lock_irqsave(&oh->_lock, flags); - _idle(oh); + r = _idle(oh); spin_unlock_irqrestore(&oh->_lock, flags); - return 0; + return r; }
Normally, such variable is called ret or res... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html