I didn't read this properly.  Will add \n in the dev_err messages.

Thanks,
  Scott

On 15-02-14 08:36 AM, Scott Branden wrote:

Hi Joe,

I really don't see the missing terminating newlines in the patch or
source code.  The lines look the same as every other line???

Regards,
  Scott

On 15-02-09 04:27 PM, Joe Perches wrote:

quoted

On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:

quoted

This adds a driver for random number generator present on Broadcom
IPROC devices.

trivia:

quoted

diff --git a/drivers/char/hw_random/iproc-rng200.c

b/drivers/char/hw_random/iproc-rng200.c

[]

quoted

+static int iproc_rng200_probe(struct platform_device *pdev)
+{

[]

quoted

+    if (!res) {
+        dev_err(dev, "failed to get rng resources");

Missing terminating newline:

        dev_err(dev, "failed to get rng resources\n");

quoted

+    rng_base = devm_ioremap_resource(dev, res);
+    if (!rng_base) {
+        dev_err(dev, "failed to remap rng regs");

here too.