On Wed, Feb 11, 2015 at 10:57 PM, Tony Lindgren [off-list ref] wrote:

quoted

quoted

+static int rproc_handle_intmem(struct rproc *rproc, struct fw_rsc_intmem *rsc,
+                              int offset, int avail)
+{

...

quoted

+       va = (__force void *)ioremap_nocache(rsc->pa, rsc->len);

Back in the days when we developed remoteproc there was a tremendous
effort to move away from ioremap when not strictly needed.

The use of ioremap in general is just fine for drivers as long
as they access a dedicated area to the specific device. Accessing
random registers and memory in the SoC is what I'm worried about.

Yes, the proposed interface essentially allows exactly this random
access, since the parameters to ioremap would be provided from the
user space (specifically from the resource table contained within the
firmware of the remote processor).

Thanks,
Ohad.