Hello Marc,

2015-02-06 17:07 GMT+08:00 Marc Zyngier [off-list ref]:

On 06/02/15 08:42, Brent Wang wrote:

[...]

quoted

quoted

quoted

+                   <0x0 0xf6802000 0x0 0x2000>, /* GICC */
+                   <0x0 0xf6804000 0x0 0x2000>, /* GICH */
+                   <0x0 0xf6806000 0x0 0x2000>; /* GICV */

I guess no-one's bothered to consider 64k pages?

Given GICH and GICV, I hope that this platform is booted at EL2?

Transfer from EL3 to EL1 directly, keep these two just for future use.

That's a real shame, as it keeps users away from some key aspects of the
ARMv8 architecture.

quoted

quoted

quoted

+             #interrupt-cells = <3>;
+             #address-cells = <0>;
+             interrupt-controller;

And if you're keeping GICH/GICV, where is the maintenance interrupt?

quoted

quoted

quoted

+     };
+
+
+     timer {
+             compatible = "arm,armv8-timer";
+             interrupt-parent = <&gic>;
+             interrupts = <1 13 0xff08>,
+                          <1 14 0xff08>,
+                          <1 11 0xff08>,
+                          <1 10 0xff08>;
+             clock-frequency = <1200000>;
+     };

NAK. Fix your firmware to configure CNTFRQ, on all CPUs.

Fix in next version, maybe it will take some time to change firmware.

While you're at it, make sure CNTVOFF_EL2 is set to zero on all CPUs
before dropping to EL1. This tends to be overlooked.

Thank you for reminding me, I will keep that in mind.

Thanks,

Thanks,

        M.
--
Jazz is not dead. It just smells funny...

-- 
Best Regards,

Bintian
===========================
Don't be nervous, just be happy!