Thread (4 messages) 4 messages, 4 authors, 2015-02-12

[PATCH] irqchip: gic: Don't complain ingic_get_cpumask() if UP system

From: stefan@agner.ch (Stefan Agner)
Date: 2015-02-01 21:26:21
Also in: lkml

On 2015-01-31 01:43, Stephen Boyd wrote:
In a uniprocessor implementation the interrupt processor targets
registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
gic_get_cpumask() will print a critical message saying

 GIC CPU mask not found - kernel will fail to boot.

if these registers all read as zero, but there won't actually be
a problem on uniprocessor systems and the kernel will boot just
fine. Skip this check if we're running a UP kernel or if we
detect that the hardware only supports a single processor.
Does the job for my device too, thx.

Acked-by: Stefan Agner <stefan@agner.ch>
quoted hunk ↗ jump to hunk
Acked-by: Nicolas Pitre <redacted>
Cc: Russell King <redacted>
Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/irqchip/irq-gic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index d617ee5a3d8a..1b70e0de0f6e 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
 			break;
 	}
 
-	if (!mask)
+	if (!mask && num_possible_cpus() > 1)
 		pr_crit("GIC CPU mask not found - kernel will fail to boot.\n");
 
 	return mask;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help