Thread (17 messages) 17 messages, 4 authors, 2015-01-31
DORMANTno replies

[PATCH 3/3] cpufreq: exynos: allow modular build

From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-01-31 22:37:01
Also in: linux-pm, linux-samsung-soc

On Friday 30 January 2015 17:51:24 Eduardo Valentin wrote:
quoted
quoted
@@ -90,6 +84,20 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
 
      If in doubt, say N.
 
+config ARM_EXYNOS5440_CPUFREQ
+   bool "SAMSUNG EXYNOS5440"
+   depends on SOC_EXYNOS5440
+   depends on HAVE_CLK && OF
+   select PM_OPP
+   default y
+   help
+     This adds the CPUFreq driver for Samsung EXYNOS5440
+     SoC. The nature of exynos5440 clock controller is
+     different than previous exynos controllers so not using
+     the common exynos framework.
+
+     If in doubt, say N.
I believe this one also has to be tristate, for the same reason.
I agree with you that it is better if we make it tristate. So, on my
side, I have no concerns changing it to tristate.

However, the exynos5440 cpufreq driver does not depend on of thermal as
of today, and therefore, I did not touch this driver for this matter.
Meaning, if it is not causing troubles, no need to mess with it.

But I can add this change. No issues, on my side.
Sorry, my mistake. I remembered incorrectly that the problem was
in both modules, but you are right that it does not exist in the exynos5440
one. It is not a mistake to turn this into tristate, but there is no
immediate neeed, so either version is fine.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help