Thread (12 messages) 12 messages, 4 authors, 2015-02-04
STALE4188d

[PATCH] mmc: moxart: fix probe logic

From: Russell King - ARM Linux <hidden>
Date: 2015-01-29 17:01:04
Also in: linux-mmc

On Thu, Jan 29, 2015 at 05:15:31PM +0100, Arnd Bergmann wrote:
quoted hunk ↗ jump to hunk
@@ -586,10 +586,10 @@ static int moxart_probe(struct platform_device *pdev)
 		goto out;
 	}
 
-	clk = of_clk_get(node, 0);
-	if (IS_ERR(clk)) {
+	host->clk = of_clk_get(node, 0);
+	if (IS_ERR(host->clk)) {
 		dev_err(dev, "of_clk_get failed\n");
-		ret = PTR_ERR(clk);
+		ret = PTR_ERR(host->clk);
 		goto out;
 	}
 
...
quoted hunk ↗ jump to hunk
@@ -677,6 +679,8 @@ static int moxart_probe(struct platform_device *pdev)
 	return 0;
 
 out:
+	if (host->clk)
+		clk_put(host->clk);
Are you sure?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help