Thread (1 message) 1 message, 1 author, 2015-01-15
DORMANTno replies

[PATCH RESEND] reset: sunxi: fix spinlock initialization

From: khilman@kernel.org (Kevin Hilman)
Date: 2015-01-15 18:37:41

Philipp Zabel [off-list ref] writes:
Hi,

Am Montag, den 12.01.2015, 14:13 -0800 schrieb Olof Johansson:
quoted
On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
quoted
On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
quoted
Call spin_lock_init() before the spinlocks are used, both in early init 
and probe functions preventing a lockdep splat.

I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
and has been tested on a few other sunxi platforms without issue.

[1]
http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
[2] http://kernelci.org/boot/?a80-optimus

Signed-off-by: Tyler Baker <redacted>
Cc: <redacted>
Acked-by: Maxime Ripard <redacted>
Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
it should probably have gone to Philipp?

We can pick it up with an ack from him though, no problem.
I have applied the patch here:

    git://git.pengutronix.de/git/pza/linux reset/for_v3.19

I was going to send a pull request tonight, but since I don't have any
other pending fixes besides this, and you already offered to pick it up,

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to arm-soc/fixes with ack from Philipp.

Thanks,

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help