[PATCH 4/9] pci: add DT based ARM Versatile PCI host driver
From: bhelgaas@google.com (Bjorn Helgaas)
Date: 2015-01-24 00:54:04
Also in:
linux-devicetree, linux-pci
Sorry for the late reply; maybe this has already been queued up somewhere, so this might be moot. I usually capitalize the "PCI" and first letter of the subject, like: PCI: Add DT based ARM Versatile PCI host driver And I try to ask for MAINTAINER updates since these drivers are under drivers/pci, but I can't maintain them all myself. On Tue, Dec 30, 2014 at 01:28:33PM -0600, Rob Herring wrote:
From: Rob Herring <robh@kernel.org> This converts the Versatile PCI host code to a platform driver using the commom DT parsing and setup. The driver uses only an empty ARM pci_sys_data struct and does not use pci_common_init_dev init function. The old host code will be removed in a subsequent commit when Versatile is completely converted to DT. I've tested this on QEMU with the sym53c8xx driver in both i/o and memory mapped modes. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci at vger.kernel.org Cc: Russell King <redacted> Cc: Linus Walleij <redacted> Cc: Peter Maydell <redacted>
Looks fine to me. Acked-by: Bjorn Helgaas <bhelgaas@google.com>
quoted hunk ↗ jump to hunk
+++ b/drivers/pci/host/pci-versatile.c...
+ /* + * We need to discover the PCI core first to configure itself + * before the main PCI probing is performed
Unusual to have two spaces between the "*" and the comments here.
+MODULE_LICENSE("GPLv2");This needs to be "GPL v2" per license_is_gpl_compatible().