Hello Ulf,

On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson [off-list ref] wrote:

 int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev)
 {
        struct mmc_pwrseq_simple *pwrseq;
+       int ret = 0;

        pwrseq = kzalloc(sizeof(struct mmc_pwrseq_simple), GFP_KERNEL);
        if (!pwrseq)
                return -ENOMEM;

+       pwrseq->reset_gpio = gpiod_get_index(dev, "reset", 0, GPIOD_OUT_HIGH);

Any reason to not use the devm_gpiod_get_index() managed version instead?

AFAICT mmc_free_host() will free the device so in that case you won't
need to call gpiod_put() in mmc_pwrseq_simple_free().

This will also make easier to extend pwrseq_simple to support multiple
GPIOs like the DT binding implies.

Best regards,
Javier