N900 v3.19-rc5 arm atags_to_fdt.c is broken

On Tuesday 27 January 2015 16:16:24 Nicolas Pitre wrote:

On Tue, 27 Jan 2015, Pavel Machek wrote:

quoted

quoted

quoted

quoted

I would say, problem is because omap3-n900 binary DT
is too large

I agree.

quoted

OK if that's the case, then your patch makes sense to
me. It also seems we can have the temporary stack be
larger than the initial stack just for atags_to_fdt.

The stack size isn't the issue, but rather its location. 
We need to position it away from the DT data.  The DT
size is known and we could use that, plus some room for
the insertion of new data coming from the ATAG
conversion.

quoted

Something like the following would be a more robust 

solution:

quoted

Tested-by: Pavel Machek <redacted>

(Note, that in 3.19 dts for n900 got too big, so we are
actually triggering old bugs. That means that this is a
regression fix, and should go in ASAP).

It is queued here:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id
=8294/1


Nicolas

I tested your patch and fdt_open_into() does not return error 
FDT_ERR_NOSPACE anymore. It is working. So you can add my

Tested-by: Pali Roh?r <redacted>

-- 
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150127/8da05adc/attachment.sig>