On 15 January 2015 at 18:26, Stephen Warren [off-list ref] wrote:

On 01/15/2015 09:12 AM, Tomeu Vizoso wrote:

quoted

To silence a warning on Nyan boards.

Signed-off-by: Tomeu Vizoso <redacted>
---
  arch/arm/boot/dts/tegra124-nyan-big.dts | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts

b/arch/arm/boot/dts/tegra124-nyan-big.dts
index 9a9cffe..94c7ba9 100644

--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts

@@ -1660,6 +1660,7 @@

                flash at 0 {
                        compatible = "winbond,w25q32dw";
+                       spi-max-frequency = <25000000>;

This property already exists in the SPI controller. Isn't the max frequency
supposed to inherit from there? If so, shouldn't the code not warn when such
inheritance happens, i.e. it'd be better to fix the code?

I don't think it's supposed to fall back to the controller's max freq,
as each device has its own maximum frequency that it can support and
it's not related to what the master supports.

Regards,

Tomeu