[PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board

Russell King - ARM Linux [off-list ref] writes:

What I'd suggest (and always have done) is:

	dev_err(&pdev->dev, "couldn't request main irq%d: %d\n",
		irq, ret);

I like it, it's even more compact, I'll use it for next patch version.

but I guess printing the IRQ number no longer makes sense with todays
dynamic mapping of logical IRQ numbers, as it is no longer meaningful.

Yes ... we're not yet there with pxa gpio interrupts, maybe it will come
eventually one day.

For Lee:

quoted

quoted

platform_get_irq()?

No. I need the flags.

Where are they used?

A couple of lines below, using local "irqflags" variable :
       ret = devm_request_irq(&pdev->dev, cot->irq, lubbock_irq_handler,
                              irqflags, dev_name(&pdev->dev), cot);

Cheers.

-- 
Robert