On Tue, Jan 20, 2015 at 05:02:06PM +0000, Iain Paton wrote:

On 16/01/15 14:03, Vishnu Patekar wrote:

quoted

Signed-off-by: VishnuPatekar <redacted>
---
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index ed364d5..3365f12 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts

@@ -113,6 +113,18 @@
 			status = "okay";
 		};
 
+		ps20: ps2 at 01c2a000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&ps20_pins_a>;
+			status = "okay";
+		};
+
+		ps21: ps2 at 01c2a400 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&ps21_pins_a>;
+			status = "okay";
+		};
+
 		i2c0: i2c at 01c2ac00 {
 			pinctrl-names = "default";
 			pinctrl-0 = <&i2c0_pins_a>;

As the Lime2 doesn't actually have any PS2 connectors on the board, 
I'd prefer that these are not enabled unconditionally. Doing so 
only makes it more difficult for people who want to use these pins 
for other functions.

Device tree overlays seem to be close to being merged, perhaps we 
could leave enabling this to an overlay?

I already had the exact same reasoning, and this was even removed at
some point. For some reason, it was added back, and I don't really
know why.

Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150120/26b1bbed/attachment.sig>