Thread (13 messages) 13 messages, 3 authors, 2015-01-20

[PATCH 3.19-rc2 v15 5/8] arm: omap1: Migrate debug_ll macros to use 8250.S

From: tony@atomide.com (Tony Lindgren)
Date: 2015-01-20 16:08:27
Also in: linux-omap, lkml

* Daniel Thompson [off-list ref] [150120 01:03]:
On 19/01/15 21:38, Tony Lindgren wrote:
quoted
* Daniel Thompson [off-list ref] [150105 04:49]:
quoted
The omap1's debug-macro.S is similar to the generic 8250 code. Compared to
the 8520 code the omap1 macro automatically determines what UART to use
based on breadcrumbs left by the bootloader and automatically copes with
the eccentric register layout on OMAP7XX.

This patch drops both these features and relies instead on the generic
8250 macros:

1. Dropping support for the bootloader breadcrumbs is identical to the
   way the migration was handled for OMAP2 (see 808b7e07464d...).

2. Support for OMAP7XX still exists but it must be configured by hand
   (DEBUG_OMAP7XXUART1/2/3) rather than handled at runtime.

Signed-off-by: Daniel Thompson <redacted>
Cc: Russell King <redacted>
Cc: Arnd Bergmann <redacted>
Cc: linux-omap at vger.kernel.org
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Tony Lindgren <tony@atomide.com>
Daniel, I suggest you upload this patch into Russell's patch tracking
system to get it merged. That at least shrinks down your patch series
if the other patches need more work.
This has been in the patch tracker for a week or so:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8271/1
OK good to hear thanks.
 
I'm very aware that this patch (and indeed the whole patch set) has been
knocking round for longer than it should have. The changelog for this
patchset is certainly not one to be especially proud off ;-) .
Yeah, it's been floating around for a while :)

Here it may have been doable to first add the Kconfig entries, then
flip them on and remove the related .S file in a follow up patch. Not
sure if that would have helped to remove the dependencies for the
rest of the series though.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help