Thread (29 messages) 29 messages, 4 authors, 2015-01-21

[RFC PATCHv2 07/19] mfd: ab8500: Use power_supply_*() API for accessing function attrs

From: Krzysztof Kozlowski <hidden>
Date: 2015-01-20 14:16:24
Also in: linux-acpi, linux-pm, lkml

On wto, 2015-01-20 at 13:36 +0000, Lee Jones wrote:
On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
quoted
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
 - get_property -> power_supply_get_property

Signed-off-by: Krzysztof Kozlowski <redacted>
Acked-by: Jonghwa Lee <redacted>
Acked-by: Pavel Machek <redacted>
Acked-by: Lee Jones <redacted>
You've sent this to me already Acked.  I don't see 00/00, so I have no
idea what's going on.  Do you want me to take this patch?  Can it be
taking on its own?
git send-email automatically CC-you because you acked this. The depends
on previous patches adding this API so please do not pick it up. 

Everything (with respective acks) should go through one power supply
tree.

The same applies to patch 18/19.

Best regards,
Krzysztof
quoted
---
 drivers/mfd/ab8500-sysctrl.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
index cfff0b643f1b..d4a4b24be7c6 100644
--- a/drivers/mfd/ab8500-sysctrl.c
+++ b/drivers/mfd/ab8500-sysctrl.c
@@ -49,7 +49,8 @@ static void ab8500_power_off(void)
 		if (!psy)
 			continue;
 
-		ret = psy->get_property(psy, POWER_SUPPLY_PROP_ONLINE, &val);
+		ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE,
+				&val);
 
 		if (!ret && val.intval) {
 			charger_present = true;
@@ -63,8 +64,8 @@ static void ab8500_power_off(void)
 	/* Check if battery is known */
 	psy = power_supply_get_by_name("ab8500_btemp");
 	if (psy) {
-		ret = psy->get_property(psy, POWER_SUPPLY_PROP_TECHNOLOGY,
-					&val);
+		ret = power_supply_get_property(psy,
+				POWER_SUPPLY_PROP_TECHNOLOGY, &val);
 		if (!ret && val.intval != POWER_SUPPLY_TECHNOLOGY_UNKNOWN) {
 			printk(KERN_INFO
 			       "Charger \"%s\" is connected with known battery."
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help