[PATCH] i2c: drop ancient protection against sysfs refcounting issues
From: Wolfram Sang <hidden>
Date: 2015-01-19 21:30:58
Also in:
linux-mips, linuxppc-dev, lkml
From: Wolfram Sang <hidden>
Date: 2015-01-19 21:30:58
Also in:
linux-mips, linuxppc-dev, lkml
quoted
@@ -1184,8 +1183,7 @@ EXPORT_SYMBOL_GPL(i2c_new_dummy); static void i2c_adapter_dev_release(struct device *dev) { - struct i2c_adapter *adap = to_i2c_adapter(dev); - complete(&adap->dev_released); + /* empty, but the driver core insists we need a release function */Yeah, it does, but I hate to see this in "real" code as something is probably wrong with it if it happens. Please move the rest of 'i2c_del_adapter' into the release function (what was after the wait_for_completion() call), and then all should be fine.
I was about to do this as a follow-up patch. But Russell's and Lars-Peter's responses made this obsolete already. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/d45fc4fc/attachment-0001.sig>