[PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver
From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-01-12 18:55:45
Also in:
linux-devicetree, lkml
On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote:
quoted
+ + dma_set_mask_and_coherent(&pdev->dev, + (sizeof(dma_addr_t) == sizeof(u64)) ? + DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); +
I commented on this on v1 already: always set the device specific mask here, it's independent of the CPU architecture, but do check the return value. Also add the correct dma-ranges property in the parent, or else this will fail in the future once we add proper checks to dma_set_mask. Arnd