Thread (22 messages) 22 messages, 8 authors, 2015-01-13

[PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix

From: kuninori.morimoto.gx@renesas.com (Kuninori Morimoto)
Date: 2015-01-09 10:07:27
Also in: alsa-devel, linux-sh, linux-tegra, lkml

Hi Stephen

Thank you for your feedback
quoted
I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
half-year (since Jun 2014) , many times. But, no-one care it.
I don't know who is the best maintainer.
 - Stephen : because it has Tegra ?
 - Olof    : because it has Tegra (= ARM) ?
 - Arnd    : because it has Tegra (= ARM) ?
 - Matthias: because it has Tegra (= ARM SoC) ?
 - Rob     : because DT ?
 - Andrew  : Last chance ?

But, could you please care this patch ?
I will re-send it again
It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
changing a DT vendor name would need that, I think.
Rob ?
I had sent this patch to him since half-years ago, many times...
Or other maintainer ?
Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
seems they expect it to go through some tree other than Tegra. Weren't
there a bunch of related patches along with this (e.g. updating relevant
drivers to support both prefixes?) so it was expected this patch would
be applied together with them?
I guess they expected it goes to DT branch (?)
This is only 1 patch. it doesn't have related patch-set
quoted
quoted
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <redacted>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
quoted
quoted
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
quoted
quoted
-ak	Asahi Kasei Corp.
quoted
quoted
+asahi-kasei	Asahi Kasei Corp.
quoted
quoted
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
quoted
quoted
 		magnetometer at c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";

Best regards
---
Kuninori Morimoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help