Thread (2 messages) flat view 2 messages, 2 authors, 2015-01-05

media: platform: s5p-jpeg: jpeg-hw-exynos4: Remove some unused functions

From: Pankaj Dubey <hidden>
Date: 2015-01-05 07:44:07
Also in: linux-media, linux-samsung-soc, lkml

+Tony Nadackal

Hi Rickard,

On Saturday 03 January 2015 02:07 AM, Rickard Strandqvist wrote:
quoted hunk ↗ jump to hunk
Removes some functions that are not used anywhere:
exynos4_jpeg_set_timer_count() exynos4_jpeg_get_frame_size() exynos4_jpeg_set_sys_int_enable() exynos4_jpeg_get_fifo_status()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>

---
drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c |   35 ---------------------
  drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.h |    5 ---
  2 files changed, 40 deletions(-)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
index ab6d6f4..5685577 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
@@ -163,15 +163,6 @@ unsigned int exynos4_jpeg_get_int_status(void __iomem *base)
  	return int_status;
  }

-unsigned int exynos4_jpeg_get_fifo_status(void __iomem *base)
-{
-	unsigned int fifo_status;
-
-	fifo_status = readl(base + EXYNOS4_FIFO_STATUS_REG);
-
-	return fifo_status;
-}
-
  void exynos4_jpeg_set_huf_table_enable(void __iomem *base, int value)
  {
  	unsigned int	reg;
@@ -186,18 +177,6 @@ void exynos4_jpeg_set_huf_table_enable(void __iomem *base, int value)
  					base + EXYNOS4_JPEG_CNTL_REG);
  }

-void exynos4_jpeg_set_sys_int_enable(void __iomem *base, int value)
-{
-	unsigned int	reg;
-
-	reg = readl(base + EXYNOS4_JPEG_CNTL_REG) & ~(EXYNOS4_SYS_INT_EN);
-
-	if (value == 1)
-		writel(reg | EXYNOS4_SYS_INT_EN, base + EXYNOS4_JPEG_CNTL_REG);
-	else
-		writel(reg & ~EXYNOS4_SYS_INT_EN, base + EXYNOS4_JPEG_CNTL_REG);
-}
-
Above function will be needed for enabling JPEG support on Exynos7 SoC. 
There is already inflight patch [1] which will be using it.

1: https://patchwork.kernel.org/patch/5505391/


Thanks,
Pankaj Dubey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help