Thread (1 message) 1 message, 1 author, 2014-12-13

[PATCH] ARM: dove: fix legacy dove IRQ numbers for 3.18

DORMANTno replies

From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2014-12-13 12:26:47

Russell King [off-list ref] writes:
v3.18 changed handle_IRQ() to call __handle_domain_irq(), which now
rejects attempts to deliver IRQ0.  Since IRQ 0 is used as the timer
interrupt (just like the PIT on x86), this causes boot to fail as the
bogomips calibration never completes.

Fix this by shuffling all interrupts up by one.
Hi Russell,

I was curious why shift by "one".
Why not shift by for example NR_IRQS_LEGACY ?

And even if you judge 1 is the right number, wouldn't it be better to define a
constant "IRQ_OFS" and have each define be "#define IRQ_xxxx (IRQ_OFS + <n>) ?

Cheers.

--
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help