Thread (10 messages) 10 messages, 5 authors, 2014-12-28

[RFC PATCH v2] drivers: pci: move PCI domain assignment to generic PCI code

From: bhelgaas@google.com (Bjorn Helgaas)
Date: 2014-12-28 01:22:49
Also in: linux-devicetree, linux-pci

On Sat, Dec 27, 2014 at 3:36 AM, Lorenzo Pieralisi
[off-list ref] wrote:
Hi Bjorn,

On Thu, Nov 20, 2014 at 10:54:49PM +0000, Bjorn Helgaas wrote:
quoted
On Mon, Nov 10, 2014 at 04:41:46PM +0000, Lorenzo Pieralisi wrote:
quoted
The current logic used for PCI domain assignment in arm64
pci_bus_assign_domain_nr() is flawed in that, depending on the host
controllers configuration for a platform and the respective initialization
sequence, core code may end up allocating PCI domain numbers from both DT and
the core code generic domain counter, which would result in PCI domain
allocation aliases/errors.

This patch fixes the logic behind the PCI domain number assignment and
moves the resulting code to generic PCI core code so that the same domain
allocation logic is used on all platforms selecting

CONFIG_PCI_DOMAINS_GENERIC

instead of resorting to an arch specific implementation that might end up
duplicating the PCI domain assignment logic wrongly.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Lorenzo Pieralisi <redacted>
Applied with Liviu and Arnd's acks to pci/domain for v3.19, thanks.

It doesn't matter whether I'm in the to: or cc: list.  The important thing
is that it appears on the linux-pci list, because I use patchwork as my
to-do list, and patchwork only vacuums up stuff from linux-pci.
This patch has not been merged last cycle and it is a prerequisite for
the ARM pcibios domain code removal patchset you merged in your pci/domain
branch. Please consider pulling it there so that the ARM pcibios domain
removal patchset can be based correctly on top of this patch, at the
moment it can't compile (see kbuild test report).
Huh, I can't remember why I didn't merge that for v3.19.  Maybe I just
missed it by mistake.

Anyway, I picked that patch into pci/domain for another try.

Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help