Hi, Sylwester

On 12/18/2014 8:13 PM, Sylwester Nawrocki wrote:

Hi Josh,

On 18/12/14 03:27, Josh Wu wrote:

quoted

Add the document for ov2640 dt.

Cc: devicetree at vger.kernel.org
Signed-off-by: Josh Wu <redacted>

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Thanks.

It seems "ovti" is not in the list of vendor prefixes. You may want
to send a patch adding it to Documentation/devicetree/bindings/
vendor-prefixes.txt.

Just few minor comments below..

quoted

  .../devicetree/bindings/media/i2c/ov2640.txt       | 46 ++++++++++++++++++++++
  1 file changed, 46 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2640.txt

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2640.txt b/Documentation/devicetree/bindings/media/i2c/ov2640.txt
new file mode 100644
index 0000000..de11ebb
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2640.txt

@@ -0,0 +1,46 @@
+* Omnivision ov2640 CMOS sensor

s/ov2640/OV2640 ?

OK.

quoted

+
+The Omnivision OV2640 sensor support multiple resolutions output, such as
+CIF, SVGA, UXGA. It also can support YUV422/420, RGB565/555 or raw RGB
+output format.
+
+Required Properties:
+- compatible: Must be "ovti,ov2640"

I believe it is preferred to put it as "Should contain", rather than
"Must be".

I don't have a strong opinion here. After check many documents, it seems 
many people use "Should be".
Is it okay?

Best Regards,
Josh Wu

quoted

+- clocks: reference to the xvclk input clock.
+- clock-names: Must be "xvclk".

--
Regards,
Sylwester