On Mon 2014-12-29 11:04:48, Guenter Roeck wrote:

On Mon, Dec 29, 2014 at 07:15:56PM +0100, Pavel Machek wrote:

quoted

On Mon 2014-12-29 12:01:03, Nishanth Menon wrote:

quoted

On Mon, Dec 29, 2014 at 11:52 AM, Grazvydas Ignotas [off-list ref] wrote:

quoted

On Fri, Dec 26, 2014 at 2:34 PM, Sebastian Reichel [off-list ref] wrote:

quoted

OMAP34xx and OMAP36xx processors contain a register in the syscon area,
which can be used to determine the SoCs temperature. This patch provides
a DT based driver for the temperature sensor based on an older driver
written by Peter De Schrijver for the Nokia N900 and N9.

The sensor looks like an earlier iteration of sensors used in newer
OMAPs, which are already supported by maybe
drivers/thermal/ti-soc-thermal/ , maybe it would make sense to update
that driver instead?

Just to be clear - OMAP4 is the first time that the sensors were
reliable enough to be used.

When testing initial version of the patch, they seem to work very well
in the omap3 case.

Pavel,

can you look into the omap4 thermal driver to see if it can be used ?

The hardware registers are named the same way...

Unfortunately, TI moves registers around with each release, and OMAP4
stuff is _way_ more complex and maze of ifdefs, too.

static struct temp_sensor_data omap4430_mpu_temp_sensor_data = {
        .min_freq = OMAP4430_MIN_FREQ,
 	.max_freq = OMAP4430_MAX_FREQ,
 	.max_temp = OMAP4430_MAX_TEMP,
	.min_temp = OMAP4430_MIN_TEMP,
 	.hyst_val = OMAP4430_HYST_VAL,
	};

and each define used just once. Would be easier to read and modify if
the ifdefs were removed...
	
Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html