Thread (4 messages) 4 messages, 3 authors, 2014-12-30

[PATCH] arm64: Fix SCTLR_EL1 initialisation

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2014-12-23 10:55:18
Also in: lkml

On Wed, Dec 17, 2014 at 05:39:16PM +0000, Will Deacon wrote:
On Wed, Dec 17, 2014 at 03:50:21PM +0000, Suzuki K. Poulose wrote:
quoted
From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>

We initialise the SCTLR_EL1 value by read-modify-writeback
of the desired bits, leaving the other bits (including reserved
bits(RESx)) untouched. However, sometimes the boot monitor could
leave garbage values in the RESx bits which could have different
implications. This patch makes sure that all the bits, including
the RESx bits, are set to the proper state, except for the
'endianness' control bits, EE(25) & E0E(24)- which are set early
in the el2_setup.

Updated the state of the Bit[6] in the comment to RES0 in the
comment.

Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
Cc: Will Deacon <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
---
Looks good to me:

  Acked-by: Will Deacon [off-list ref]

Is this 3.19 material, or simply a cleanup/being cautious?
I'll leave this for the 3.20 merging window.

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help