[PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver
From: joe@perches.com (Joe Perches)
Date: 2014-12-19 22:27:01
Also in:
linux-devicetree, linux-input, lkml
On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote:
Add initial version of the Broadcom touchscreen driver.
more trivia:
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c b/drivers/input/touchscreen/bcm_iproc_tsc.c
[]
+static int get_tsc_config(struct device_node *np, struct iproc_ts_priv *priv)
+{
+ u32 val;[]
+ if (of_property_read_u32(np, "debounce_timeout", &val) >= 0) {
+ if (val < 0 || val > 255) {
+ dev_err(dev, "debounce_timeout must be [0-255]\n");
+ return -EINVAL;
+ }
+ priv->cfg_params.debounce_timeout = val;Doesn't the compiler generate a warning message about an impossible "unsigned < 0" test for all of these "val < 0" uses?
+ }
+
+ if (of_property_read_u32(np, "settling_timeout", &val) >= 0) {
+ if (val < 0 || val > 11) {[]
+ if (of_property_read_u32(np, "touch_timeout", &val) >= 0) {
+ if (val < 0 || val > 255) {[]
+ if (of_property_read_u32(np, "average_data", &val) >= 0) {
+ if (val < 0 || val > 8) {[]
+ if (of_property_read_u32(np, "fifo_threshold", &val) >= 0) {
+ if (val < 0 || val > 31) {