[PATCH 2/4] irqchip: mediatek: Add support for mt8173
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-12-10 15:52:04
Also in:
linux-devicetree, lkml
On Wednesday 10 December 2014 22:37:13 Yingjoe Chen wrote:
OK, I'll change to something like this in next version:
I've just taken another look at the driver and have a different suggestion:
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt@@ -17,12 +17,17 @@ Required properties: use the same interrupt-cells format as GIC. - reg: Physical base address of the intpol registers and length of memory mapped region. +Optional properties: +- mediatek,intpol-number: The number of interrupts supported by intpol, + default 224 if omitted. + Example: sysirq: interrupt-controller at 10200100 { compatible = "mediatek,mt6589-sysirq", "mediatek,mt6577-sysirq"; interrupt-controller; #interrupt-cells = >; interrupt-parent = <&gic>; reg = <0 0x10200100 0 0x1c>; + mediatek,intpol-number = <224>; };
The number of interrupt pins directly corresponds to the size of the reg property in bits, so I think you can just use that and don't even need another property. Arnd